Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(realtime): remove jwt check #658

Merged
merged 3 commits into from
Feb 10, 2025
Merged

fix(realtime): remove jwt check #658

merged 3 commits into from
Feb 10, 2025

Conversation

grdsdev
Copy link
Collaborator

@grdsdev grdsdev commented Feb 7, 2025

Also:

  • Call setAuth after heartbeat
  • Send x-client-info when joining channel

@grdsdev
fix(realtime): remove jwt check
c74ce06 
Also:
- Call `setAuth` after heartbeat
- Send `x-client-info` when joining channel
@grdsdev
fix tests
778cd26
@grdsdev
only send token if changed
898619c
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13199357228

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 74.478%
Files with Coverage Reduction New Missed Lines %
Sources/Realtime/RealtimeClientV2.swift 1 69.01%
Sources/Helpers/JWT.swift 1 89.29%
Totals Coverage Status
Change from base Build 13157350725: -0.02%
Covered Lines: 4996
Relevant Lines: 6708
💛 - Coveralls

@grdsdev grdsdev requested a review from dshukertjr February 7, 2025 12:35
@grdsdev grdsdev merged commit 4c95559 into main Feb 10, 2025
20 of 21 checks passed
@grdsdev grdsdev deleted the guilherme/fix/remove-jwt-check branch February 10, 2025 10:49
@github-actions github-actions bot mentioned this pull request Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshukertjr dshukertjr dshukertjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grdsdev @coveralls @dshukertjr